Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note: Display the same module twice on one slide #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KristjanESPERANTO
Copy link
Collaborator

It took me a little time to figure this out and someone else on the forum stumbled across it too.

@shbatm
Copy link
Owner

shbatm commented Feb 23, 2022

Good catch for the workaround, but this is not how it's intended. It looks like I've got some flawed logic here by breaking out of the loop on a non-match: it stops looking for modules with the same name but different carouselId on the same slide config.

I'd guess you could probably also trick it by adding the modules to the slide with different carouselIds but in the reverse order they are listed in your config (bottom-up).

I will leave this PR open for now as a reminder, but I'm going to try and revisit the logic when I get a chance.

@KristjanESPERANTO
Copy link
Collaborator Author

And I thought it was supposed to be like this and I'm just having trouble understanding it 😅

@shbatm
Copy link
Owner

shbatm commented Feb 23, 2022

Nope, just bad logic. It was intended to allow the same module with different configs to be shown on different slides, but didn't take into consideration the same module, different configs, same slide.

@paulsp
Copy link

paulsp commented May 31, 2022

See the example in #36. CarouselId section-2-detail demonstrates two entries with the same id

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants