Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors in the Large Hail Parameter (LHP) calculation #248

Open
dustwx28 opened this issue Apr 6, 2023 · 0 comments
Open

Errors in the Large Hail Parameter (LHP) calculation #248

dustwx28 opened this issue Apr 6, 2023 · 0 comments

Comments

@dustwx28
Copy link

dustwx28 commented Apr 6, 2023

Regarding the Large Hail Parameter (LHP) calculation:

I submit the following corrections to SHARPpy for the LHP calculation in params.py based on communication with A. Johnson NWS:

  1. Kelliecook has already submitted this first issue as “lhp calculation error lhp calculation error #220” on 2 September 2021:
    Lines
    455 if term_a < 0:
    456 term_a = 0
    and lines
    474 if term_b < 0:
    475 term_b = 0

It should be:
If term_a < 0 AND term_b < 0 then LHP = 0

Additionally:
2) Lines 464 and 465
464 If grw_alpha_el > 180:
465 grw_alpha_el = -10

Instead it should be:
If grw_alpha_el > 180
Then the entirety of the term, (grw_alpha_el + 5)/20 = -10 in line 472

and lastly:
3) after line 477 lhp = term_a * term_b + 5
Check again that LHP is NOT < 0 to avoid ever having a negative LHP. If lhp < 0 at this point, set lhp = 0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant