Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): restrict 'cat' tests to unix environments. Fixes #776 #777

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ritvikos
Copy link

Tests using the cat command are specific to Unix-like environments and will fail on unsupported platforms.
Restrict these tests to unix environments only.

Tests using the 'cat' command are specific
to unix-like environments and
fail on unsupported platforms.
@sharkdp
Copy link
Owner

sharkdp commented Dec 1, 2024

Thank you for reporting this and for opening a PR. It would be great if we could test this behavior on Windows somehow. Maybe we can find a Windows replacement for cat? Doesn't need to be a cat-equivalent. Just something that we can pass input to. And check if it received the input correctly.

@ritvikos
Copy link
Author

ritvikos commented Dec 2, 2024

Great idea!
Found that type is the replacement of cat in Windows.
Now the tests work fine 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants