From 69d2c3834cd9c4ca50f3904acbc7619fbe8fce69 Mon Sep 17 00:00:00 2001 From: paradajz <2544094+paradajz@users.noreply.github.com> Date: Sun, 15 Oct 2023 08:18:55 +0200 Subject: [PATCH] remove support for viewtech touchscreens --- README.md | 2 +- src/firmware/application/CMakeLists.txt | 1 - .../application/io/touchscreen/Touchscreen.h | 1 - .../io/touchscreen/model/Builder.cpp | 1 - .../io/touchscreen/model/Builder.h | 4 +- .../io/touchscreen/model/viewtech/README.md | 3 - .../touchscreen/model/viewtech/Viewtech.cpp | 181 ------------------ .../io/touchscreen/model/viewtech/Viewtech.h | 55 ------ .../io/touchscreen/stub/Touchscreen.h | 1 - tests/src/system/CMakeLists.txt | 1 - 10 files changed, 2 insertions(+), 248 deletions(-) delete mode 100644 src/firmware/application/io/touchscreen/model/viewtech/README.md delete mode 100644 src/firmware/application/io/touchscreen/model/viewtech/Viewtech.cpp delete mode 100644 src/firmware/application/io/touchscreen/model/viewtech/Viewtech.h diff --git a/README.md b/README.md index 71f0de128..317944da0 100644 --- a/README.md +++ b/README.md @@ -27,7 +27,7 @@ The following components are supported: * Potentiometers * FSRs (force-sensitive resistors) * LCD/OLED displays -* Touchscreen displays (Nextion and Viewtech/Stone) +* Touchscreen displays (Nextion) OpenDeck supports sending of both 7-bit and 14-bit Non-Registered Part Numbers (NRPN), latching messages on buttons, various encoding modes for quadrature encoders, LED control using MIDI In, configurable MIDI channels for each component individually, Bluetooth MIDI etc. Full list of supported features can be found [here](https://github.com/shanteacontrols/OpenDeck/wiki/Configurable-features). diff --git a/src/firmware/application/CMakeLists.txt b/src/firmware/application/CMakeLists.txt index 76ea8439c..fb1d0e6b7 100644 --- a/src/firmware/application/CMakeLists.txt +++ b/src/firmware/application/CMakeLists.txt @@ -50,7 +50,6 @@ if(NOT "PROJECT_TARGET_USB_OVER_SERIAL_HOST" IN_LIST PROJECT_TARGET_DEFINES) target_sources(application PRIVATE ${CMAKE_CURRENT_LIST_DIR}/io/buttons/Buttons.cpp - ${CMAKE_CURRENT_LIST_DIR}/io/touchscreen/model/viewtech/Viewtech.cpp ${CMAKE_CURRENT_LIST_DIR}/io/touchscreen/model/Builder.cpp ${CMAKE_CURRENT_LIST_DIR}/io/touchscreen/model/nextion/Nextion.cpp ${CMAKE_CURRENT_LIST_DIR}/io/touchscreen/Touchscreen.cpp diff --git a/src/firmware/application/io/touchscreen/Touchscreen.h b/src/firmware/application/io/touchscreen/Touchscreen.h index f99e19a25..9965f57fd 100644 --- a/src/firmware/application/io/touchscreen/Touchscreen.h +++ b/src/firmware/application/io/touchscreen/Touchscreen.h @@ -102,7 +102,6 @@ namespace io enum class model_t : uint8_t { NEXTION, - VIEWTECH, AMOUNT }; diff --git a/src/firmware/application/io/touchscreen/model/Builder.cpp b/src/firmware/application/io/touchscreen/model/Builder.cpp index b5053ebc7..6f1bea5e0 100644 --- a/src/firmware/application/io/touchscreen/model/Builder.cpp +++ b/src/firmware/application/io/touchscreen/model/Builder.cpp @@ -24,7 +24,6 @@ using namespace io; TouchscreenModelBuilder::TouchscreenModelBuilder(Touchscreen::HWA& hwa) : _nextion(hwa) - , _viewtech(hwa) {} uint8_t Touchscreen::Model::_rxBuffer[Touchscreen::Model::BUFFER_SIZE]; diff --git a/src/firmware/application/io/touchscreen/model/Builder.h b/src/firmware/application/io/touchscreen/model/Builder.h index 4eceb4454..a82bd2aa6 100644 --- a/src/firmware/application/io/touchscreen/model/Builder.h +++ b/src/firmware/application/io/touchscreen/model/Builder.h @@ -23,7 +23,6 @@ limitations under the License. #ifdef PROJECT_TARGET_SUPPORT_TOUCHSCREEN #include "nextion/Nextion.h" -#include "viewtech/Viewtech.h" namespace io { @@ -33,8 +32,7 @@ namespace io TouchscreenModelBuilder(Touchscreen::HWA& hwa); private: - Nextion _nextion; - Viewtech _viewtech; + Nextion _nextion; }; } // namespace io #else diff --git a/src/firmware/application/io/touchscreen/model/viewtech/README.md b/src/firmware/application/io/touchscreen/model/viewtech/README.md deleted file mode 100644 index e000baa75..000000000 --- a/src/firmware/application/io/touchscreen/model/viewtech/README.md +++ /dev/null @@ -1,3 +0,0 @@ -This directory contains code support for Viewtech SDWe displays. Currently tested displays: - -* SDWe101T09T (1024x600, 10", resistive touchscreen) \ No newline at end of file diff --git a/src/firmware/application/io/touchscreen/model/viewtech/Viewtech.cpp b/src/firmware/application/io/touchscreen/model/viewtech/Viewtech.cpp deleted file mode 100644 index 16a12a2f0..000000000 --- a/src/firmware/application/io/touchscreen/model/viewtech/Viewtech.cpp +++ /dev/null @@ -1,181 +0,0 @@ -/* - -Copyright 2015-2022 Igor Petrovic - -Licensed under the Apache License, Version 2.0 (the "License"); -you may not use this file except in compliance with the License. -You may obtain a copy of the License at - - http://www.apache.org/licenses/LICENSE-2.0 - -Unless required by applicable law or agreed to in writing, software -distributed under the License is distributed on an "AS IS" BASIS, -WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -See the License for the specific language governing permissions and -limitations under the License. - -*/ - -#ifdef PROJECT_TARGET_SUPPORT_TOUCHSCREEN - -#include "Viewtech.h" -#include "core/Timing.h" -#include "core/util/Util.h" - -using namespace io; - -Viewtech::Viewtech(io::Touchscreen::HWA& hwa) - : _hwa(hwa) -{ - io::Touchscreen::registerModel(io::Touchscreen::model_t::VIEWTECH, this); -} - -bool Viewtech::init() -{ - Touchscreen::Model::_bufferCount = 0; - - if (_hwa.init()) - { - // add slight delay to ensure display can receive commands after power on - core::timing::waitMs(3000); - - return true; - } - - return false; -} - -bool Viewtech::deInit() -{ - return _hwa.deInit(); -} - -bool Viewtech::setScreen(size_t screenID) -{ - screenID &= 0xFF; - - _hwa.write(0xA5); - _hwa.write(0x5A); - _hwa.write(0x04); - _hwa.write(0x80); - _hwa.write(0x03); - _hwa.write(0x00); - _hwa.write(screenID); - - return true; -} - -Touchscreen::tsEvent_t Viewtech::update(Touchscreen::tsData_t& data) -{ - auto event = Touchscreen::tsEvent_t::NONE; - uint8_t value = 0; - - while (_hwa.read(value)) - { - Touchscreen::Model::_rxBuffer[Touchscreen::Model::_bufferCount++] = value; - } - - // assumption - only one response is received at the time - // if parsing fails, wipe the buffer - if (Touchscreen::Model::_bufferCount) - { - // verify header first - if (Touchscreen::Model::_rxBuffer[0] == 0xA5) - { - if (Touchscreen::Model::_bufferCount > 1) - { - if (Touchscreen::Model::_rxBuffer[1] == 0x5A) - { - if (Touchscreen::Model::_bufferCount > 2) - { - // byte at index 2 holds response length, without first two bytes and without byte at index 2 - if (Touchscreen::Model::_bufferCount >= static_cast(3 + Touchscreen::Model::_rxBuffer[2])) - { - uint32_t response = Touchscreen::Model::_rxBuffer[2]; - response <<= 8; - response |= Touchscreen::Model::_rxBuffer[3]; - response <<= 8; - response |= Touchscreen::Model::_rxBuffer[4]; - response <<= 8; - response |= Touchscreen::Model::_rxBuffer[5]; - - switch (response) - { - case static_cast(response_t::BUTTON_STATE_CHANGE): - { - data.buttonState = Touchscreen::Model::_rxBuffer[6]; - data.buttonID = Touchscreen::Model::_rxBuffer[7]; - - event = Touchscreen::tsEvent_t::BUTTON; - } - break; - - default: - break; - } - - Touchscreen::Model::_bufferCount = 0; - } - } - } - else - { - // header invalid - ignore the rest of the message - Touchscreen::Model::_bufferCount = 0; - } - } - } - else - { - // header invalid - ignore the rest of the message - Touchscreen::Model::_bufferCount = 0; - } - } - - return event; -} - -void Viewtech::setIconState(Touchscreen::icon_t& icon, bool state) -{ - // header - _hwa.write(0xA5); - _hwa.write(0x5A); - - // request size - _hwa.write(0x05); - - // write variable - _hwa.write(0x82); - - // icon address - for viewtech displays, address is stored in xPos element - _hwa.write(core::util::MSB_U16(icon.xPos)); - _hwa.write(core::util::LSB_U16(icon.xPos)); - - // value to set - 2 bytes are used, higher is always 0 - // inverted logic for setting state - 0 means on state, 1 is off - _hwa.write(0x00); - _hwa.write(state ? 0x00 : 0x01); -} - -bool Viewtech::setBrightness(Touchscreen::brightness_t brightness) -{ - // header - _hwa.write(0xA5); - _hwa.write(0x5A); - - // request size - _hwa.write(0x03); - - // register write - _hwa.write(0x80); - - // brightness settting - _hwa.write(0x01); - - // brightness value - _hwa.write(BRIGHTNESS_MAPPING[static_cast(brightness)]); - - return true; -} - -#endif \ No newline at end of file diff --git a/src/firmware/application/io/touchscreen/model/viewtech/Viewtech.h b/src/firmware/application/io/touchscreen/model/viewtech/Viewtech.h deleted file mode 100644 index 8515da2c4..000000000 --- a/src/firmware/application/io/touchscreen/model/viewtech/Viewtech.h +++ /dev/null @@ -1,55 +0,0 @@ -/* - -Copyright 2015-2022 Igor Petrovic - -Licensed under the Apache License, Version 2.0 (the "License"); -you may not use this file except in compliance with the License. -You may obtain a copy of the License at - - http://www.apache.org/licenses/LICENSE-2.0 - -Unless required by applicable law or agreed to in writing, software -distributed under the License is distributed on an "AS IS" BASIS, -WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -See the License for the specific language governing permissions and -limitations under the License. - -*/ - -#pragma once - -#include -#include "application/io/touchscreen/Touchscreen.h" -#include "core/util/RingBuffer.h" - -class Viewtech : public io::Touchscreen::Model -{ - public: - Viewtech(io::Touchscreen::HWA& hwa); - - bool init() override; - bool deInit() override; - bool setScreen(size_t screenID) override; - io::Touchscreen::tsEvent_t update(io::Touchscreen::tsData_t& data) override; - void setIconState(io::Touchscreen::icon_t& icon, bool state) override; - bool setBrightness(io::Touchscreen::brightness_t brightness) override; - - private: - enum class response_t : uint32_t - { - BUTTON_STATE_CHANGE = 0x05820002 - }; - - io::Touchscreen::HWA& _hwa; - - // there are 7 levels of brighness - scale them to available range (0-64) - static constexpr uint8_t BRIGHTNESS_MAPPING[7] = { - 6, - 16, - 32, - 48, - 51, - 58, - 64 - }; -}; \ No newline at end of file diff --git a/src/firmware/application/io/touchscreen/stub/Touchscreen.h b/src/firmware/application/io/touchscreen/stub/Touchscreen.h index bd3bd21b2..0fff7b0d0 100644 --- a/src/firmware/application/io/touchscreen/stub/Touchscreen.h +++ b/src/firmware/application/io/touchscreen/stub/Touchscreen.h @@ -92,7 +92,6 @@ namespace io enum class model_t : uint8_t { NEXTION, - VIEWTECH, AMOUNT }; diff --git a/tests/src/system/CMakeLists.txt b/tests/src/system/CMakeLists.txt index 58d7368a4..505a62b58 100644 --- a/tests/src/system/CMakeLists.txt +++ b/tests/src/system/CMakeLists.txt @@ -20,7 +20,6 @@ if(NOT "PROJECT_TARGET_USB_OVER_SERIAL_HOST" IN_LIST PROJECT_TARGET_DEFINES) ${PROJECT_ROOT}/src/firmware/application/io/touchscreen/Touchscreen.cpp ${PROJECT_ROOT}/src/firmware/application/io/touchscreen/model/Builder.cpp ${PROJECT_ROOT}/src/firmware/application/io/touchscreen/model/nextion/Nextion.cpp - ${PROJECT_ROOT}/src/firmware/application/io/touchscreen/model/viewtech/Viewtech.cpp ) target_compile_definitions(system