Skip to content
This repository has been archived by the owner on Oct 9, 2018. It is now read-only.

User can't leave comment if it already sign in #89

Open
krydos opened this issue Dec 7, 2013 · 3 comments
Open

User can't leave comment if it already sign in #89

krydos opened this issue Dec 7, 2013 · 3 comments

Comments

@krydos
Copy link
Contributor

krydos commented Dec 7, 2013

If "Enable for comments" option is checked then user can't leave a message if it already sign in. (hope you understand what I mean).

I can illustrated this.

If option set on true:
opt_selected

then:
then

See? I logged now and I can't leave the comment. But when I unchecked the option I have the button for leaving comments:
screenshot at 2013-12-07 19 50 25

This happens because user shouldn't signing to the site if user already authorized.
In code it's look like that:

if (!is_user_logged_in()) {
    $this->ui->Print_persona_button_html(
        "js-persona__submit-comment", $this->button_html);
}

We have IF but we do not have ELSE. I guess if user is authorized already we must show default comment button.

This sounds not so hard and if you don't mind I can try fix this :)

@krydos
Copy link
Contributor Author

krydos commented Dec 7, 2013

I did not make changes into Is_comments() function because this function must be return a value from database regardless of the situation (IMHO).

@shane-tomlinson
Copy link
Owner

Thank you very much @krydos - I will try to have a look at your fix this week when I get a few free moments!

@kitchin
Copy link

kitchin commented Jan 27, 2014

Looks like this was fixed a different way on trac for the 0.48 release:
https://plugins.trac.wordpress.org/changeset?new=773867%40browserid%2Ftrunk&old=773173%40browserid%2Ftrunk

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants