Skip to content
This repository has been archived by the owner on Oct 9, 2018. It is now read-only.

Link to "What is Persona" doesn't go to the corresponding language page at m.o #35

Open
MagicFab opened this issue Jul 10, 2013 · 1 comment

Comments

@MagicFab
Copy link

When logged out, having comments login support enabled in the plugin, the persona logo is shown with an accompanying link "What is persona?" which goes to https://login.persona.org/. It seems instead it should go to the corresponding URI in the appropriate language. It doesn't help that login.p.o does not have a language switcher, I assume it does browser detection.

When using a localized version of WordPress, the link is always the same despite there existing localized versions:
French: https://support.mozilla.org/fr/kb/quest-persona-comment-ca-marche
Spanish: https://support.mozilla.org/es/kb/que-es-y-como-funciona-mozilla-persona
etc.

The URL should be in the language file for proper language support - but putting it there would hardcode it.

@MagicFab
Copy link
Author

After reading a bit more of Persona's dev documentation, I realize it's expected that the browser provides the context for deciding in which language this is presented.

However, it's still desirable to change this language and so far the browser does not permit this in a usable fashion - ou have to go into browser preferences, change the preferred language and reload. As a result pretty much any multilingual site may take into account such preferences but always provides a way to override it.

All localizable strings currently presented in this plugins preferences page should then be part of the language file for appropriate localization.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant