From c0d776a02e634cdd86b23e73de4352be0360c100 Mon Sep 17 00:00:00 2001 From: Shamindra Shrotriya Date: Wed, 31 Mar 2021 23:41:04 -0400 Subject: [PATCH 01/35] Initiate PR - empty commit From 73643b8ca564a02d75497632e1aea88fbe2300e5 Mon Sep 17 00:00:00 2001 From: Shamindra Shrotriya Date: Thu, 1 Apr 2021 08:59:21 -0400 Subject: [PATCH 02/35] Increment version number --- DESCRIPTION | 2 +- NEWS.md | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/DESCRIPTION b/DESCRIPTION index f13452ba..72e72428 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -1,6 +1,6 @@ Package: maars Title: Tidy Inference Under Misspecified Statistical Models in R -Version: 1.0.0 +Version: 1.1.0 Authors@R: c(person(given = "Shamindra", family = "Shrotriya", diff --git a/NEWS.md b/NEWS.md index a5e4d4d4..07aa87dc 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,3 +1,5 @@ +# maars 1.1.0 + # maars 1.0.0 - Set the default `digits = 3` formatting in `summary.maars_lm` printed output From 4595c0aeea0c24ed03bba82923776a03143f67a0 Mon Sep 17 00:00:00 2001 From: Shamindra Shrotriya Date: Thu, 1 Apr 2021 14:59:21 -0400 Subject: [PATCH 03/35] FT: #60 Add all authors with cph, add AK to authors, update NEWS --- DESCRIPTION | 10 ++-- NEWS.md | 34 ++++++++++++++ docs/404.html | 4 +- docs/CODE_OF_CONDUCT.html | 4 +- docs/CONTRIBUTING.html | 4 +- docs/LICENSE-text.html | 4 +- docs/LICENSE.html | 4 +- docs/SUPPORT.html | 4 +- docs/articles/index.html | 4 +- docs/articles/se-la-county-data.html | 4 +- docs/authors.html | 12 +++-- docs/index.html | 9 ++-- docs/news/index.html | 47 ++++++++++++++++++- docs/pkgdown.yml | 2 +- docs/reference/as.maars.html | 4 +- docs/reference/boston_housing.html | 4 +- docs/reference/check_fn_args.html | 4 +- .../check_fn_args_comp_mms_var_boot.html | 4 +- .../check_fn_args_comp_mms_var_boot_ind.html | 4 +- docs/reference/check_fn_args_posint.html | 4 +- docs/reference/check_fn_args_summary.html | 4 +- docs/reference/comp_boot_emp.html | 4 +- docs/reference/comp_boot_emp_samples.html | 4 +- docs/reference/comp_boot_mul.html | 4 +- docs/reference/comp_boot_mul_ind.html | 4 +- docs/reference/comp_boot_mul_wgt.html | 4 +- docs/reference/comp_boot_res.html | 4 +- docs/reference/comp_ci_boot.html | 4 +- docs/reference/comp_lm_var.html | 4 +- docs/reference/comp_mms_var.html | 4 +- docs/reference/comp_sand_var.html | 4 +- docs/reference/comp_var.html | 4 +- docs/reference/confint.maars_lm.html | 4 +- docs/reference/diag_boot_qqn.html | 4 +- docs/reference/diag_fit_reg_rwgt.html | 4 +- docs/reference/diag_fit_reg_rwgt_single.html | 4 +- docs/reference/diag_foc_rwgt.html | 4 +- docs/reference/diag_foc_slope.html | 4 +- docs/reference/diag_nl_detect.html | 4 +- docs/reference/fetch_mms_comp_var_attr.html | 4 +- docs/reference/fetch_mms_emoji_title.html | 4 +- docs/reference/fit_reg.html | 4 +- docs/reference/gen_grid_cent_rwgt.html | 4 +- docs/reference/get_assumptions.html | 4 +- docs/reference/get_boot_summary.html | 4 +- docs/reference/get_confint.html | 4 +- docs/reference/get_mms_assumptions_cli.html | 4 +- docs/reference/get_mms_print_cli.html | 4 +- .../get_mms_summary_confint_split_cli.html | 4 +- docs/reference/get_mms_summary_split_cli.html | 4 +- .../reference/get_mms_summary_with_stars.html | 4 +- docs/reference/get_plot.html | 4 +- docs/reference/get_summary.html | 4 +- docs/reference/index.html | 4 +- docs/reference/la_county.html | 4 +- docs/reference/maars-package.html | 9 ++-- docs/reference/pipe.html | 4 +- docs/reference/plot.maars_lm.html | 4 +- docs/reference/print.maars_lm.html | 4 +- docs/reference/print.summary.maars_lm.html | 4 +- docs/reference/set_mms_ggplot2_theme.html | 4 +- docs/reference/summary.maars_lm.html | 4 +- docs/reference/tidyeval.html | 4 +- man/maars-package.Rd | 5 +- 64 files changed, 220 insertions(+), 132 deletions(-) diff --git a/DESCRIPTION b/DESCRIPTION index 72e72428..62e1ef3f 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -4,12 +4,16 @@ Version: 1.1.0 Authors@R: c(person(given = "Shamindra", family = "Shrotriya", - role = c("aut", "cre"), + role = c("aut", "cre", "cph"), email = "shamindra.shrotriya@gmail.com"), person(given = "Riccardo", family = "Fogliato", - role = c("aut"), - email = "rfogliat@andrew.cmu.edu")) + role = c("aut", "cph"), + email = "rfogliat@andrew.cmu.edu"), + person(given = "Arun Kumar", + family = "Kuchibhotla", + role = c("aut", "cph"), + email = "karun3kumar@gmail.com")) Description: Tidy Inference Under Misspecified Statistical Models in R. An implementation of the Models As Approximations series of statistics papers. License: MIT + file LICENSE diff --git a/NEWS.md b/NEWS.md index 07aa87dc..82a8d6b9 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,5 +1,39 @@ # maars 1.1.0 +- Change `Significance` heading in our summary output to be abbreviated to `Signif:` to be consistent with `lm()` output +- Change column ordering for bootstrap standard errors and t-statistics rigorously +- Change p-value format to be `2`/`3` digits +- Clean `R/scripts_and_filters/experiments/` dir, remove old experiments +- Clean up script that gets metadata of `maars` function **metadata** from `pkgdown` +- Remove all `base::` prefix use e.g. `base::return()` +- Change `dplyr::summarise` to `dplyr::summarize` for spelling consistency +- Ensure all `stats` functions use the `stats::` prefix +- Fix `.data` related `rlang` issues +- We shouldn't name a variable `df` since this conflicts with `stats::df`. We should change this after the demo +- Clean vignette. Leave the plot in the vignette (to be moved elsewhere) +- Updated the corrected `Boston Housing` Dataset with citations. Add unit tests +for the corrections +- Clean up spelling notes +- Change multiplier weights code to use `switch` based approach +- Switch to `model.matrix` in sandwich variance and use residuals in the computation +- Update `maars` to have a package level doc. Add `@importFrom` statements +- Fix `NOTE` by adding `.gitkeep` in vignettes to `.RBuildignore` +- Fix `NOTE` by DESCRIPTION meta-information by making it a couple of sentences. This is a placeholder and we should refine it before official `CRAN` release. +- Consolidate `boston-housing.R` and `la-county.R` files into a single `data-maars.R` files. Consolidate `test` files accordingly +- Make some minor changes to the vignette +- Add `styling` to our code using the `Makefile` and `styler::style_dir(here::here('R'))` +and for `tests` +- Have a `make style` which does both `R` and `tests` +- Make sure styling does not include vignettes +- Ensure that `url_check()` are all resolved for `CRAN` +- Remove DOI entries from `inst/REFERENCES.bib` since they can cause `CRAN` url issues +- Add search functionality to `pkgdown` our site. +- Use MIT License +- Fix the no visible binding for global variable errors in our code +- Remove mixture of `%>%` and base code, and just break pipes into variables +- Change all `attr(obj, "class") <- c("obj_class_name")` to be of the form `class(obj) <- "obj_class_name"` for consistency +- Change `dplyr::_all` scoped words using the superseded `across` function + # maars 1.0.0 - Set the default `digits = 3` formatting in `summary.maars_lm` printed output diff --git a/docs/404.html b/docs/404.html index beec1843..0fb1ee1a 100644 --- a/docs/404.html +++ b/docs/404.html @@ -77,7 +77,7 @@ maars - 1.0.0 + 1.1.0 @@ -162,7 +162,7 @@

Contents