From 60b0ec09b3e0e46243d879d34b657016f851a9a0 Mon Sep 17 00:00:00 2001 From: Judah Meek Date: Wed, 26 Jun 2024 01:27:58 -0500 Subject: [PATCH] whatever --- .github/workflows/main.yml | 1 + spec/dummy/spec/rake/assets_precompile_rake_spec.rb | 3 ++- spec/dummy/spec/rake/assets_rake_spec.rb | 2 +- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 9cdd3d84d..1a6f8c660 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -84,6 +84,7 @@ jobs: dummy-app-integration-tests: needs: build-dummy-app-webpack-test-bundles strategy: + fail-fast: false matrix: versions: ['oldest', 'newest'] runs-on: ubuntu-22.04 diff --git a/spec/dummy/spec/rake/assets_precompile_rake_spec.rb b/spec/dummy/spec/rake/assets_precompile_rake_spec.rb index 9c03ce3aa..690f6e491 100644 --- a/spec/dummy/spec/rake/assets_precompile_rake_spec.rb +++ b/spec/dummy/spec/rake/assets_precompile_rake_spec.rb @@ -3,6 +3,7 @@ require "rake" require "rails_helper" +require "react_on_rails" describe "rake assets:precompile task" do it "doesn't show deprecation message for using webpacker:clean task" do @@ -12,7 +13,7 @@ Rails.application.load_tasks ReactOnRails.configure do |config| - config.build_production_command = "RAILS_ENV=production NODE_ENV=production bin/shakapacker" + config.build_production_command = "RAILS_ENV=production NODE_ENV=production bin/#{ReactOnRails::PackerUtils.packer_type}" end expect do diff --git a/spec/dummy/spec/rake/assets_rake_spec.rb b/spec/dummy/spec/rake/assets_rake_spec.rb index 000af74c8..6d2f798fa 100644 --- a/spec/dummy/spec/rake/assets_rake_spec.rb +++ b/spec/dummy/spec/rake/assets_rake_spec.rb @@ -35,7 +35,7 @@ def self.call Rake::Task["react_on_rails:assets:webpack"].execute - expect(BuildProductionCommand).to have_received(:call) + expect(BuildProductionCommand).to have_received(:call).twice expect(File).to exist(filepath) end