Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: port HLS module to CMake #1238

Merged
merged 9 commits into from
Aug 22, 2023
Merged

feat: port HLS module to CMake #1238

merged 9 commits into from
Aug 22, 2023

Conversation

cosmin
Copy link
Contributor

@cosmin cosmin commented Jul 17, 2023

Related to issue #1047

@cosmin
Copy link
Contributor Author

cosmin commented Aug 5, 2023

rebased now that cmake port of mpd has landed, next I'll need to address some of the same feedback from the MPD branch here (starting with FlagSaver)

packager/hls/base/simple_hls_notifier.cc Outdated Show resolved Hide resolved
packager/hls/base/simple_hls_notifier.cc Outdated Show resolved Hide resolved
@cosmin cosmin marked this pull request as ready for review August 5, 2023 15:51
@cosmin
Copy link
Contributor Author

cosmin commented Aug 5, 2023

My clang-format locally and the Github Actions clang-format seem to be doing different things for this change in GenerateSegmentUrl. For now I applied the patch out of the failing Github Actions check locally.

@cosmin cosmin requested a review from joeyparrish August 5, 2023 15:57
@joeyparrish
Copy link
Member

Looks good, except for Windows build failures like:

packager\hls\base\simple_hls_notifier.cc(239,16): error C2664: 'bool shaka::hls::MediaPlaylist::WriteToFile(const std::string &)': cannot convert argument 1 from 'std::filesystem::path' to 'const std::string &'

@cosmin cosmin force-pushed the cmake-hls branch 3 times, most recently from c08898f to a5df4c7 Compare August 19, 2023 00:03
@cosmin
Copy link
Contributor Author

cosmin commented Aug 19, 2023

the problem is that on Windows there is no implicit conversion of std::filesystem::path to std::string (instead on Windows it can convert to std::wstring) whereas on Linux/Mac there is. Going to take a few iterations to flush out all usages by waiting for the Windows checks to run.

@cosmin cosmin force-pushed the cmake-hls branch 3 times, most recently from da27757 to 9900b3f Compare August 19, 2023 04:32
@cosmin
Copy link
Contributor Author

cosmin commented Aug 19, 2023

Fixing docs build in #1257

@cosmin cosmin merged commit ab8485c into shaka-project:cmake Aug 22, 2023
27 of 31 checks passed
@cosmin cosmin deleted the cmake-hls branch August 22, 2023 01:41
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Oct 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants