-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: port HLS module to CMake #1238
Conversation
92651c1
to
fa148f6
Compare
2e253ae
to
bd2b773
Compare
rebased now that cmake port of mpd has landed, next I'll need to address some of the same feedback from the MPD branch here (starting with FlagSaver) |
My |
Looks good, except for Windows build failures like:
|
c08898f
to
a5df4c7
Compare
the problem is that on Windows there is no implicit conversion of std::filesystem::path to std::string (instead on Windows it can convert to std::wstring) whereas on Linux/Mac there is. Going to take a few iterations to flush out all usages by waiting for the Windows checks to run. |
da27757
to
9900b3f
Compare
Fixing docs build in #1257 |
Related to issue #1047