fix: Populate requested scheme into output, not default scheme #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that the polyfill will respond with more than one scheme on Firefox and Chromecast devices, we must populate the _requested_ scheme into the output, not the _default_ scheme. Back when the polyfill assumed that only the default was possible, these were the same, so this distinction didn't matter.
avelad
approved these changes
May 14, 2024
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the polyfill will respond with more than one scheme on Firefox and Chromecast devices, we must populate the requested scheme into the output, not the default scheme.
Back when the polyfill assumed that only the default was possible, these were the same, so this distinction didn't matter.