Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR gets stuck when there are only document changes #5689

Closed
jkwak-work opened this issue Nov 26, 2024 · 5 comments
Closed

PR gets stuck when there are only document changes #5689

jkwak-work opened this issue Nov 26, 2024 · 5 comments
Labels
goal:quality & productivity Quality issues and issues that impact our productivity coding day to day inside slang

Comments

@jkwak-work
Copy link
Collaborator

When PR has only document files changed, the CI gets stuck.
"build"-s are not supposed to be triggered but they are.
I am not sure if it related to the recent change with "licence/cla" action.

image

@jkwak-work jkwak-work added the goal:quality & productivity Quality issues and issues that impact our productivity coding day to day inside slang label Nov 26, 2024
@jkwak-work
Copy link
Collaborator Author

@expipiplus1
Copy link
Collaborator

It is because that CI ignores changes restricted to the docs directory, this is safe to ignore. Or we can unconditionally run such workflows

@jkwak-work
Copy link
Collaborator Author

Why does the build workflows are triggered in the first place?
The label checking workflow seems to be doing fine as expected in a way that it is not triggered at all.
They seem to have the same path-ignore settings.

@csyonghe
Copy link
Collaborator

csyonghe commented Dec 2, 2024

The tests are showing up because the repo is configured to expect these tests to pass, when in fact they are not triggered. This is just a github display issue, and no tests are actually stuck.

@csyonghe
Copy link
Collaborator

csyonghe commented Dec 2, 2024

See https://github.com/shader-slang/slang/settings/branch_protection_rules/1102224 under "Require status checks to pass before merging"

expipiplus1 added a commit to expipiplus1/slang that referenced this issue Dec 4, 2024
expipiplus1 added a commit to expipiplus1/slang that referenced this issue Dec 4, 2024
expipiplus1 added a commit to expipiplus1/slang that referenced this issue Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
goal:quality & productivity Quality issues and issues that impact our productivity coding day to day inside slang
Projects
None yet
Development

No branches or pull requests

3 participants