Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remap and rename #13

Open
hmonnery opened this issue Sep 27, 2022 · 0 comments
Open

Remap and rename #13

hmonnery opened this issue Sep 27, 2022 · 0 comments

Comments

@hmonnery
Copy link

Hi,

I've run into a couple of issues with remap and rename. Apologies if it's just my own mistakes!

  • When using solve_impulse_linear, it seems like remapping a solved block gives an error, because the H_U_factored uses the remapped notation, whereas the rest of the internal block doesn't.
  • Remapping a simple block seems to cause problems too, because self.inputs is remapped but compared to internal variable names.
  • Renaming when a Parent has attribute .block, rather than .blocks, doesn't rename the children of .block, when they exist.

I've attached a notebook with minimal examples. Please let me know if there are issues.

Thanks!!
Hugo

Remap.ipynb.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant