Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZkConnection not really thread-safe #82

Open
facboy opened this issue Oct 28, 2019 · 0 comments
Open

ZkConnection not really thread-safe #82

facboy opened this issue Oct 28, 2019 · 0 comments

Comments

@facboy
Copy link

facboy commented Oct 28, 2019

ZkConnection does not really look thread-safe to me. It locks _zk for the connect and close methods, but _zk itself is not volatile so there are no visibility guarantees when it is accessed by all the other methods.

as an aside, ReentrantLock could easily be replaced by a synchronized block/method in connect and close.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@facboy