Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variant positions less than one? #1176

Open
hyanwong opened this issue Jan 22, 2024 · 1 comment
Open

Variant positions less than one? #1176

hyanwong opened this issue Jan 22, 2024 · 1 comment

Comments

@hyanwong
Copy link

I'm assuming that variant positions must be 1 or greater in an sgkit dataset. Is this part of the spec, or enforced anywhere? I looked through the docs and couldn't find anything. I assume setting position to -1 will also break stuff?

In tskit the positions start at 0, so there's a bit of trickery needed in my use-case, I suspect.

@tomwhite
Copy link
Collaborator

tomwhite commented Feb 5, 2024

Variant positions can start at 0 or 1 - it's not enforced in sgkit. There's some discussion in #434.

I assume setting position to -1 will also break stuff?

I'm not sure. What's the use case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants