-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extra .exe suffix on windows, possible regression in 0.11.x #324
Comments
I think I have worked around the windows-only failures I was seeing with executable_name = select({
- "@bazel_tools//src/conditions:windows": "%target%.exe",
+ "@bazel_tools//src/conditions:windows": "%target%",
"//conditions:default": "%target%",
}), I think the default value of the attribute has a similar select, so it still seems like there's an underlying issue here that could affect other users of rules_graalvm: Lines 48 to 51 in d6bde1f
|
@cushon Thanks for reporting. I intend to look into this today, a bit swamped but I should be able to get to it quickly |
Hey @cushon, Firstly, thanks for your patience and workaround. "Today" turned into two weeks before I even noticed. The current behavior in the rules is to treat In the original behavior, the binary name was set unconditionally to The original The rule you have cited above (under That being said, the modern entrypoint does this same thing: rules_graalvm/graalvm/nativeimage/rules.bzl Lines 28 to 31 in 024d4e3
rules_graalvm/graalvm/nativeimage/rules.bzl Lines 66 to 68 in 024d4e3
I suppose we could:
Personally I think approach 1 is fine, but I wanted to get your take first in case I might be missing something. @fmeum if you have any thoughts they are welcome. |
Thanks for digging in to this! The approach 1 you described sounds fine to me too. For what it's worth I'm still slightly confused about where the duplicate |
Oh, I see what you mean now. That's a good question, I'll double check. |
I'm updating Bazel's use of rules_graalvm from 0.10.3 to 0.11.1, and from GraalVM 20.0.2 to 21.0.2, and am seeing a failure where it looks like the handling of
executable_name
had changed on windows:The build logs contain
The usage of
native_image
is configuring a windows-specific path with the.exe
suffix. It's overriding the defaults to drop the-bin
suffix that's added:https://github.com/bazelbuild/bazel/blob/4420fffb00794405a334d55c9c5c53669a217f05/src/java_tools/buildjar/java/com/google/devtools/build/java/turbine/BUILD#L29-L34
It looks like an extra suffix is being added somewhere, so it's resulting in
.exe.exe
on windows.I wondered if this is related to #217, but from the build logs it looks like native-image is being invoked with
-o turbine_direct_graal.exe
.The text was updated successfully, but these errors were encountered: