From 7f2e5570256ccd97d7be5572464cb04d021f7dc4 Mon Sep 17 00:00:00 2001 From: Sam Gammon Date: Sun, 29 Sep 2024 13:01:17 -0700 Subject: [PATCH] fix: remove `incompatible_remote_results_ignore_disk` Fixes and closes sgammon/rules_graalvm#409 Signed-off-by: Sam Gammon --- .aspect/bazelrc/performance.bazelrc | 6 ------ tools/bazel/cache.bazelrc | 1 - tools/bazel/strict.bazelrc | 1 - 3 files changed, 8 deletions(-) diff --git a/.aspect/bazelrc/performance.bazelrc b/.aspect/bazelrc/performance.bazelrc index fff4c7c5..93c25d85 100644 --- a/.aspect/bazelrc/performance.bazelrc +++ b/.aspect/bazelrc/performance.bazelrc @@ -7,12 +7,6 @@ build --noexperimental_check_output_files fetch --noexperimental_check_output_files query --noexperimental_check_output_files -# Don't apply `--noremote_upload_local_results` and `--noremote_accept_cached` to the disk cache. -# If you have both `--noremote_upload_local_results` and `--disk_cache`, then this fixes a bug where -# Bazel doesn't write to the local disk cache as it treats as a remote cache. -# Docs: https://bazel.build/reference/command-line-reference#flag--incompatible_remote_results_ignore_disk -build --incompatible_remote_results_ignore_disk - # Directories used by sandboxed non-worker execution may be reused to avoid unnecessary setup costs. # Save time on Sandbox creation and deletion when many of the same kind of action run during the # build. diff --git a/tools/bazel/cache.bazelrc b/tools/bazel/cache.bazelrc index 95eed402..41bff817 100644 --- a/tools/bazel/cache.bazelrc +++ b/tools/bazel/cache.bazelrc @@ -5,7 +5,6 @@ build:buildless --remote_cache=https://global.less.build build --modify_execution_info=PackageTar=+no-remote build --remote_local_fallback -build --incompatible_remote_results_ignore_disk build --noexperimental_check_output_files build --nolegacy_important_outputs build --incompatible_default_to_explicit_init_py diff --git a/tools/bazel/strict.bazelrc b/tools/bazel/strict.bazelrc index 0ecd1357..38b9d169 100644 --- a/tools/bazel/strict.bazelrc +++ b/tools/bazel/strict.bazelrc @@ -19,7 +19,6 @@ build:strict --incompatible_no_attr_license build:strict --incompatible_py2_outputs_are_suffixed build:strict --incompatible_py3_is_default build:strict --incompatible_remote_output_paths_relative_to_input_root -build:strict --incompatible_remote_results_ignore_disk build:strict --incompatible_remote_symlinks build:strict --incompatible_remove_legacy_whole_archive build:strict --incompatible_require_ctx_in_configure_features