-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not work after upgrade to Home Assistant 2025.1.0 #267
Comments
Same to me: Logger: homeassistant.setup Setup failed for custom integration 'victron': Unable to import component: No module named 'pymodbus.register_read_message' |
I am also having the same issue, i have had to revert back |
Same problem here |
Here’s a potential fix:
After making this change and restarting Home Assistant, everything seems to work fine for me. |
Yes, it works for me too as workaround. But the big question here is: Does the intergation work 100% without this line and without Holding Registers? Since generally Holding Registers are very important, if you use ModBus. And I do not know, if the intergation really needs this line or not. |
I have same sort of issues. |
This issue should be closed as it is an exact duplicate of #263 |
Yes, but the workaround solution from here should be publicated in #263 too, since the solution from #263 with forked repository and manual change first to this fork and thereafter back to the "original" repository is not really a good idea. The proposed workaround with comment out of one line is better. Because, if the "original" HACS will be fixed in the next future, you do not need this disclaimer "please not forget to change back to the original repository" |
Thanks @BMG80 |
Hello. It worked perfectly for me too. Thank you very much. @BMG80 |
Please mark this issue as duplicate, close it and let us continue the discussion in #263 |
funciona con actualizacion Home Assistant Abra el archivo /config/custom_components/victron/coordinator.py. Comente la línea 14, que importa ReadHoldingRegistersResponse: from pymodbus.register_read_message import ReadHoldingRegistersResponseReiniciar Home Assistant. Después de realizar este cambio y reiniciar Home Assistant, todo parece funcionar bien para mí.👍👍 |
Can someone close this issue as duplicate, please!!! |
works for me, too . Good job ! |
Also for me (done yesterday). However, there might be some hidden unwanted side effects I'm not comfortable with - thus, hope for an official fix |
Tha
Muito Obrigado... Excelent. |
Hi all! Because this repo is maintained and i also like to use my Victron equipment in HA i made a new repo that you can use: https://github.com/remcom/hass-victron My goals:
Feel free to make your own pr's on the new branch or make issues on stuff you running into. Also if there are fellow maintainers that want to join please send me a message |
Worked! Thanks! |
Switched to @remcom 's repo and it's working great! Thanks! Easy instructions on how to switch too btw. |
Ok, thanksEnviado desde Outlook para AndroidDe: aihngel ***@***.***>Enviado: domingo, enero 12, 2025 3:15:55 a. m.Para: sfstar/hass-victron ***@***.***>CC: Marjaletes ***@***.***>; Comment ***@***.***>Asunto: Re: [sfstar/hass-victron] Not work after upgrade to Home Assistant 2025.1.0 (Issue #267)
Switched to @remcom 's repo and it's working great! Thanks! Easy instructions on how to switch too btw.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: ***@***.***>
|
hello, after upgrade to 2025.1.0 this integration stop work.
the log is:
Registratore: homeassistant.setup
Fonte: setup.py:334
Prima occorrenza: 23:38:13 (1 occorrenze)
Ultimo accesso: 23:38:13
Setup failed for custom integration 'victron': Unable to import component: No module named 'pymodbus.register_read_message'
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/setup.py", line 334, in _async_setup_component
component = await integration.async_get_component()
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/loader.py", line 1035, in async_get_component
self._component_future.result()
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^
File "/usr/src/homeassistant/homeassistant/loader.py", line 1015, in async_get_component
comp = await self.hass.async_add_import_executor_job(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
self._get_component, True
^^^^^^^^^^^^^^^^^^^^^^^^^
)
^
File "/usr/local/lib/python3.13/concurrent/futures/thread.py", line 59, in run
result = self.fn(*self.args, **self.kwargs)
File "/usr/src/homeassistant/homeassistant/loader.py", line 1075, in _get_component
ComponentProtocol, importlib.import_module(self.pkg_path)
~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/util/loop.py", line 200, in protected_loop_func
return func(*args, **kwargs)
File "/usr/local/lib/python3.13/importlib/init.py", line 88, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "", line 1387, in _gcd_import
File "", line 1360, in _find_and_load
File "", line 1331, in _find_and_load_unlocked
File "", line 935, in _load_unlocked
File "", line 1026, in exec_module
File "", line 488, in _call_with_frames_removed
File "/config/custom_components/victron/init.py", line 9, in
from .coordinator import victronEnergyDeviceUpdateCoordinator as Coordinator
File "/config/custom_components/victron/coordinator.py", line 14, in
from pymodbus.register_read_message import ReadHoldingRegistersResponse
ModuleNotFoundError: No module named 'pymodbus.register_read_message'
The text was updated successfully, but these errors were encountered: