Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repackage goenvtemplator to use more recent sprig library #12

Open
freznicek opened this issue Aug 15, 2017 · 5 comments
Open

Repackage goenvtemplator to use more recent sprig library #12

freznicek opened this issue Aug 15, 2017 · 5 comments

Comments

@freznicek
Copy link

Repackage goenvtemplator to use more recent sprig library

Currently goenvtemplator uses quite old sprig library, it would be great to move to more recent version to support advanced functions like regexReplaceAll.

$ goenvtemplator2 -version
2017/08/15 14:28:46 Version: -2.0.0-rc2
$ goenvtemplator2 -template $PWD/index.html.tmpl:$PWD/index.htmL
2017/08/15 14:28:14 Error while generating '/home/freznicek/prjs/szn/sources/Sklik-DevOps/helm-registry.git/docs/index.html.tmpl' -> '/home/freznicek/prjs/szn/sources/Sklik-DevOps/helm-registry.git/docs/index.htmL'. template: index.html.tmpl:8: function "regexReplaceAll" not defined

It looks that goenvtemplator2 uses this particular revision https://github.com/Masterminds/sprig/tree/69011c0cd9b4d2e0733c4d9e2c8e2a5a0d0a2f2f which is from Dec 2016.

@freznicek
Copy link
Author

Current workaround is to use replace instead of more powerfull regexReplaceAll.

@dohnto
Copy link

dohnto commented Aug 15, 2017

This has no priority for us right now. Not working on this for at least next 2 weeks. Will be back soon.

@FUSAKLA
Copy link
Collaborator

FUSAKLA commented Jun 7, 2018

This becomes more and more important since Sprig changed their functions radically and upgrade would already introduce breaking change.

The problem is that Sprig documentation has only the latest version so there is no documentation for the Sprig version we support now already.

@dohnto
Copy link

dohnto commented Sep 16, 2018

Should we support this in v2?

@FUSAKLA
Copy link
Collaborator

FUSAKLA commented Sep 16, 2018

I say let's upgrade it now in v2 when we have the chance to introduce breaking changes.
Otherwise we would wait next 2 years for another major release :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants