Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bad loop #92

Open
Shpoike opened this issue Jan 16, 2024 · 1 comment
Open

bad loop #92

Shpoike opened this issue Jan 16, 2024 · 1 comment

Comments

@Shpoike
Copy link

Shpoike commented Jan 16, 2024

https://github.com/sezero/quakespasm/blob/master/Quake/r_world.c#L131
by pre-skipping leaf 0 (as required by pvs), that array reads 1 leaf and 1 pvsbit beyond the end of their respective arrays, which could result in bad reads or even writes.

@sezero
Copy link
Owner

sezero commented Jan 16, 2024

Do you have a patch?

CC: @andrei-drexler, @ericwa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants