Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deduplicate base64 #26013

Closed
nox opened this issue Mar 23, 2020 · 10 comments · Fixed by #29804
Closed

Deduplicate base64 #26013

nox opened this issue Mar 23, 2020 · 10 comments · Fixed by #29804
Labels
I-cleanup No impact; the issue is one of maintainability or tidiness.

Comments

@nox
Copy link
Contributor

nox commented Mar 23, 2020 •
edited
Loading

Latest release is 0.12, brought in crate tree through #26005.

Dependencies that already depend on 0.12 that we need to bump on our side:

  • headers
    • warp
    • hyper_serde

Dependencies on 0.10 that Mozilla people maintain:

  • webdriver (depends on warp)
  • webrender

Dependencies on 0.10 that require upstream changes:

  • influent

Dependencies on 0.11 that require upstream changes:
@Eijebong
Copy link
Contributor

For info: webdriver -> https://bugzilla.mozilla.org/show_bug.cgi?id=1606281

@Eijebong
Copy link
Contributor

Also I just published influent 0.5.3 with base64 0.12

@Eijebong
Copy link
Contributor

Influent will also need an update for tokio. Is it really something useful for servo ? I'm currently kind of maintaining for dep updates but I don't have any real motivation to do so.

@atouchet atouchet mentioned this issue Nov 16, 2020
Merged
5 tasks
bors-servo added a commit that referenced this issue Nov 16, 2020
@bors-servo
Auto merge of #27767 - atouchet:base64, r=jdm
9e76eb6 
Dedupe base64 0.11

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix (part of) #26013

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
bors-servo added a commit that referenced this issue Nov 16, 2020
@bors-servo
Auto merge of #27767 - atouchet:base64, r=jdm
7bfa917 
Dedupe base64 0.11

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix (part of) #26013

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@atouchet
Copy link
Contributor

atouchet commented May 22, 2023 •
edited
Loading

base64 0.12 was removed in #29766.

@jdm
Copy link
Member

jdm commented May 22, 2023

rust-ammonia/rust-content-security-policy#36

@jdm
Copy link
Member

jdm commented May 22, 2023

hyperium/headers#140

@jdm jdm added the I-cleanup No impact; the issue is one of maintainability or tidiness. label May 22, 2023
@dvtkrlbs
Copy link
Contributor

I looked at this issue for bumping to 0.21.2. The problem is this bumps MSRV and some crates are reluctant to also bump it i.e headers. Should we go with base64 or switch to data encoding. Which still uses 0.47 as MSRV and API is still very similiar to previous base64 api design.

@jdm
Copy link
Member

jdm commented May 28, 2023

I'm not sure if switching to data-encoding will make a big difference unless we convince all of the crates that currently depend on base64 to switch as well.

@dvtkrlbs
Copy link
Contributor

Ok that makes sense I will open a pr for updating to 0.21.2. There are still a few upstream crates that are on 0.10 and 0.13 but there is nothing other than waiting for them.

@dvtkrlbs dvtkrlbs mentioned this issue May 28, 2023
Merged
4 tasks
bors-servo added a commit that referenced this issue May 28, 2023
@bors-servo
Auto merge of #29804 - dvtkrlbs:bump-base64, r=jdm
c698d74 
bump base64 from 0.10 to 0.21

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes partly fix #26013

- [x] These changes do not require tests because it bumps version of a dependency. From running the tests there does not seem to be any regressions (there are a lot of crashed tests but I don't think they are relevant to this change)

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
bors-servo added a commit that referenced this issue May 28, 2023
@bors-servo
Auto merge of #29804 - dvtkrlbs:bump-base64, r=jdm
03725b9 
bump base64 from 0.10 to 0.21

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes partly fix #26013

- [x] These changes do not require tests because it bumps version of a dependency. From running the tests there does not seem to be any regressions (there are a lot of crashed tests but I don't think they are relevant to this change)

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
@atouchet atouchet reopened this Aug 2, 2023
@atouchet
Copy link
Contributor

This was done in #30415.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I-cleanup No impact; the issue is one of maintainability or tidiness.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bump base64 from 0.10 to 0.21 dvtkrlbs/servo
5 participants
@jdm @nox @Eijebong @dvtkrlbs @atouchet