Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid AWS Access Key ID #188

Open
liam-ot opened this issue Jul 3, 2023 · 1 comment
Open

Invalid AWS Access Key ID #188

liam-ot opened this issue Jul 3, 2023 · 1 comment

Comments

@liam-ot
Copy link

liam-ot commented Jul 3, 2023

Describe the bug
AWS has updated their access key ID naming pattern which results in a breaking change when using VTL templates, serverless-offline, and this repo

I would be happy to open a PR but i dont know how to, i have the repo locally and the changes in a branch but i cannot push, instead git suggests i fork and push to that, is that the correct way to do it?

To Reproduce
Use a VTL template

Expected behavior
The VTL template should complete the request

Additional context
I have a branch locally with the fix, it is two lines in the index.js file where the underscores are removed from the access key and secret.

@domdomegg
Copy link

git suggests i fork and push to that, is that the correct way to do it?

Yes, I suspect this is the correct way to go about making a contribution.

These two docs articles may be relevant:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants