-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle the case of an empty rendered string in Plurr preview #467
Comments
@iafan By plurr we mean this: https://github.com/loctools/plurr ? |
@benjamimo1 correct! |
… in Plurr preview
If we input all necessary strings: Is "Empty string rendered" a different case scenario as "Please enter placeholder"? |
Yes, these are different cases. The first one is when you have missing (empty) placeholder values. The second one is an empty string as returned from Plurr formatting function. In your screenshot above, you will never get an empty string in the output, regardless of the parameters. But there can be units which may produce an empty string as an output. See this example (try to change N to |
OK, will give it a look now, assuming two different cases. |
When the rendered string is empty, let's provide a different message, e.g. "Empty string rendered", rather than saying "Please enter placeholder <...>" (see the screenshot)
The text was updated successfully, but these errors were encountered: