Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submitting translations removes quality check submissions #354

Open
julen opened this issue Aug 30, 2018 · 0 comments
Open

Submitting translations removes quality check submissions #354

julen opened this issue Aug 30, 2018 · 0 comments
Labels

Comments

@julen
Copy link
Contributor

julen commented Aug 30, 2018

When a unit contains submissions related to changes in quality checks (mute/unmute), these are properly reflected in the timeline.

However, when a new translation is provided (including an empty string), quality checks for that unit are deleted, and with that, due to the ON DELETE CASCADE behavior, the Submissions for the unit are deleted as well. After this, the timeline no longer reflects the past changes to muting/unmuting quality checks.

Changing the ON DELETE behavior to SET NULL wouldn't help because we need to have access to the quality check name, which is in the now-removed QualityCheck. We can alternatively denormalize the check name into Submission, but we should be aware that that requires increasing the size of the submissions table for a limited use case, plus schema and data migrations.

@julen julen added the bug label Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant