Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2690 by adding a type which allows lazily creating attachments which only get resolved at request time. The
Clone
requirement means that we can't store theReader
types directly, which is unfortunate but not too bad.Draft for now because I don't know how to concisely add support to the
create_*
builders. Adding support to theedit_*
builders was easy by just adding anEditAttachments::add_stream
method. However, thecreate_*
builders have three separate methods for adding attachments:add_file
,add_files
, andfiles
. Duplicating all three to accommodate the streaming variant seems quite noisy.