Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider having Provided solely block the scanner, not the Tributary #366

Closed
kayabaNerve opened this issue Aug 31, 2023 · 3 comments
Closed
Labels
coordinator improvement This could be better

Comments

@kayabaNerve
Copy link
Member

Provided halting the Tributary was a safety feature, yet it has the DoS of preventing the 33% who have yet to receive the Provided Transaction from participating in consensus. By having verify_block still reject it, yet add_block handle it, we prevent this DoS.

There'd still be the guarantee 67% have come to sync on the item, and the scanner still waiting for the Provided transaction to be locally provided will ensure safety.

This should reduce risk of stutters in Tendermint.

@kayabaNerve kayabaNerve added improvement This could be better coordinator labels Aug 31, 2023
@kayabaNerve
Copy link
Member Author

https://github.com/serai-dex/serai/actions/runs/6238640448/job/16934913654 failed, likely due to a proposer who was late on a Provided failing to propose, adding several seconds of latency to the run.

@kayabaNerve
Copy link
Member Author

To clarify, a proposer late on a Provided did fail to propose. The "likely" is referring to that being THE reason the run failed. Not due to uncertainty about that event occurring.

@kayabaNerve
Copy link
Member Author

Fixed by #381.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
coordinator improvement This could be better
Projects
None yet
Development

No branches or pull requests

1 participant