Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block proposer algorithm #159

Closed
kayabaNerve opened this issue Nov 14, 2022 · 3 comments
Closed

Block proposer algorithm #159

kayabaNerve opened this issue Nov 14, 2022 · 3 comments
Labels
improvement This could be better tendermint

Comments

@kayabaNerve
Copy link
Member

Currently, sc-tendermint has an unweighted round robin without context on how many rounds previous blocks took. This should at least be a weighted round robin with context. Ideally, this would be SASSAFRAS (or something akin to SASSAFRAS), as per #134.
@kayabaNerve kayabaNerve added improvement This could be better substrate labels Nov 14, 2022
@kayabaNerve kayabaNerve mentioned this issue Nov 14, 2022
Merged
@kayabaNerve
Copy link
Member Author

To be clear, this issue is for a movement to a better block proposer algorithm, even if it still has the DoS issue. That would mean weighting + ideally context on blocks which took multiple rounds.

@kayabaNerve kayabaNerve mentioned this issue Jan 26, 2023
Closed
kayabaNerve added a commit that referenced this issue Mar 26, 2023
@kayabaNerve
Remove Tendermint for GRANDPA
aea6ac1 
Updates to polkadot-v0.9.40, with a variety of dependency updates accordingly.
Substrate thankfully now uses k256 0.13, pathing the way for #256. We couldn't
upgrade to polkadot-v0.9.40 without this due to polkadot-v0.9.40 having
fundamental changes to syncing. While we could've updated tendermint, it's not
worth the continued development effort given its inability to work with
multiple validator sets.

Purges sc-tendermint. Keeps tendermint-machine for #163.

Closes #137, #148, #157, #171. #96 and #99 should be re-scoped/clarified. #134
and #159 also should be clarified. #169 is also no longer a priority since
we're only considering temporal deployments of tendermint. #170 also isn't
since we're looking at effectively sharded validator sets, so there should
be no singular large set needing high performance.
@kayabaNerve
Copy link
Member Author

Per aea6ac1, Tendermint is now only relevant to #163. That shouldn't require an advanced block proposer algorithm, being a whitelisted network. I'm fine closing this.

@kayabaNerve kayabaNerve closed this as not planned Won't fix, can't repro, duplicate, stale Mar 26, 2023
@kayabaNerve kayabaNerve mentioned this issue Mar 26, 2023
Closed
@kayabaNerve
Copy link
Member Author

If we ever re-open this, the discussion should be on https://ethresear.ch/t/whisk-a-practical-shuffle-based-ssle-protocol-for-ethereum/11763.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement This could be better tendermint
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kayabaNerve @TheArchitect108