Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data_store follow-ups #227

Open
eseiler opened this issue Sep 10, 2024 · 0 comments
Open

data_store follow-ups #227

eseiler opened this issue Sep 10, 2024 · 0 comments

Comments

@eseiler
Copy link
Member

eseiler commented Sep 10, 2024

1: void data_store::validate()

  • We need to test whether data_store is set up correctly before we start executing hierarchical binning.

2: Refactor data_store

  • If config is stored in data_store, the data_store can get a constructor that initialises some members, e.g., the FPR correction, via IIILE. This would be more error proof.
  • The data_store is not very intuitive (and should be restructured) because it contains members that:
    • are given externally and are always const
    • are given externally but change in recursive calls (e.g. positions)
    • are local but const
    • are local but will change in iterations of the DP (e.g. union_estimation)

Originally posted by @smehringer in #224 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant