Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fnv.h and murmur.h appear to be stubs #22

Open
b4hand opened this issue Jun 18, 2015 · 1 comment
Open

fnv.h and murmur.h appear to be stubs #22

b4hand opened this issue Jun 18, 2015 · 1 comment

Comments

@b4hand
Copy link
Contributor

b4hand commented Jun 18, 2015

The files fnv.h and murmur.h appear to be stubs and don't actually implement any hashing function.

Additionally, murmur.h does not contain a proper include guard.

The jenkins hash is the only valid implementation. I don't know if this is intentional or not, but it seems like it would be a good idea to drop these files if there's no plans of filling them in.
@pombredanne
Copy link

These have removed for a while... Can we close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pombredanne @b4hand