Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor PSL Regular Expressions #45

Open
NassimBtk opened this issue Mar 15, 2024 · 0 comments
Open

Refactor PSL Regular Expressions #45

NassimBtk opened this issue Mar 15, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@NassimBtk
Copy link
Member

NassimBtk commented Mar 15, 2024

Use Case

Connectors use regular expressions here and there, but these are supposed to be regular expressions for the PSL grep() function, which has a very particular syntax (\| instead of just | for the logical or, e.g.).

We can't expect external users to know about PSL regular expressions, which are also very limited. We want to be able to support anything that Java regular expressions support.

Specification

Each connector will be able to specify the type of regular expressions it's using, with a top-level option in YAML:

regexType: psl # or java

Default value will be java (we're in 2024 after all).

If regexType == "psl", then we "convert" the specified regular expression to the corresponding Java regular expression. Otherwise, we leave it as is.

We will update all existing connectors to specify regexType: psl, for backward compatibility.

@alexdgilbert alexdgilbert removed their assignment Apr 24, 2024
@bertysentry bertysentry added the enhancement New feature or request label Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants