Tiff tasks parameter folder renamed to path
#768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlubej
reviewed
Nov 3, 2023
Co-authored-by: Matic Lubej <[email protected]>
|
thanks for the new docstrings, much clearer 🙇 |
mlubej
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's often not a folder, so it's very confusing...
Ellipsis as a default seemed like the best way to signal that this might still be required (using
Nonewould be odd).TiffTask(feature, my_path)works as beforeTiffTask(feature)will raise aTypeErrorthat the parameterpathis missing (similar to what would happen before)TiffTask(feature, path=my_path)works as intendedTiffTask(feature, folder=my_path)also works as previously intended, but also warns the user