Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud mask task should use s2cloudless #723

Merged
merged 3 commits into from
Aug 25, 2023

Conversation

mlubej
Copy link
Contributor

@mlubej mlubej commented Aug 25, 2023

Changes:

  • new requirement for eo-learn-mask (s2cloudless)
  • simplified CloudMaskTask after using S2PixelCloudDetector from s2cloudless

I expected the test data to change and the tests to fail, since the eo-learn version was using a different version of the s2cloudless model (or seemed to be). Doesn't seem to be any change in the tests, so this one is a freebie.

@mlubej mlubej requested a review from zigaLuksic August 25, 2023 12:19
@mlubej mlubej self-assigned this Aug 25, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 25, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (7bef48a) 88.71% compared to head (7bef48a) 88.71%.

❗ Current head 7bef48a differs from pull request most recent head 50a3c3c. Consider uploading reports for the commit 50a3c3c to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #723   +/-   ##
========================================
  Coverage    88.71%   88.71%           
========================================
  Files           57       57           
  Lines         5652     5652           
========================================
  Hits          5014     5014           
  Misses         638      638           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mlubej mlubej merged commit 58c6dfa into develop Aug 25, 2023
@mlubej mlubej deleted the cloud-mask-task-s2c-requirement branch August 25, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants