-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
access to http server instance #127
Comments
@afoninsky We'd definitely be open to a PR on this. |
not that experienced yet to extending seneca; but interested in this feature (providing health check for the service); what would be the simplest approach (two url would be needed) ? |
Same question as @bbnnt , is what is the recommended way for health check? Just |
@bbnnt I looked at the sources, and found you can call |
Server instance created in local scope, not accessible by my code: https://github.com/senecajs/seneca-transport/blob/master/lib/http.js#L23
Can we extend http server (or append ability to pass it via config, or do whatever else according your module rules)?
Usecase: i want to pass socket into my favorite http framework (express/hapi/koa) and setup health-check routes (example for google: "GET /_ah/health" tells google what my microservice is alive)
The text was updated successfully, but these errors were encountered: