Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for {load$: true} params when remove$ is executed #23

Closed
mirceaalexandru opened this issue Nov 12, 2015 · 5 comments
Closed

Add tests for {load$: true} params when remove$ is executed #23

mirceaalexandru opened this issue Nov 12, 2015 · 5 comments

Comments

@mirceaalexandru
Copy link
Contributor

No description provided.

@mirceaalexandru
Copy link
Contributor Author

I will do this, cannot assign to me for some reason

@mirceaalexandru mirceaalexandru changed the title Add tests for {all$: false} and {load$: true} params when remove$ is executed Add tests for {load$: true} params when remove$ is executed Nov 12, 2015
@paolochiodi
Copy link
Contributor

You may want to look into this PR #18 that already contains those tests

@mirceaalexandru
Copy link
Contributor Author

It's OK, I just need it updated to latest specifications for stores and published so I use them for my tests.

@paolochiodi
Copy link
Contributor

Yep, that PR should bring all tests up to the latest specs, but it's waiting review before getting merged

geek added a commit that referenced this issue Nov 12, 2015
@geek
Merge pull request #24 from mirceaalexandru/master
0a5f4f6 
Add tests for {load$: true} params when remove$ is executed. Add linting. See #23
@paolochiodi
Copy link
Contributor

Fixed in the merged PR: #18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@paolochiodi @mirceaalexandru