Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opaque ids spec not implemented correctly #6

Open
mihaidma opened this issue Apr 29, 2016 · 0 comments
Open

opaque ids spec not implemented correctly #6

mihaidma opened this issue Apr 29, 2016 · 0 comments

Comments

@mihaidma
Copy link
Collaborator

mihaidma commented Apr 29, 2016

A string as the first parm position is an opaque id:
senecajs/seneca-store-test#16 (comment)

The query builder implements something like (https://github.com/senecajs/seneca-standard-query/blob/master/lib/query-builder.js#L378):

function buildSelectStatementCustom (qent, q, sTypes, selectstm, selectstmOr, done) {
    var query

    if (_.isString(q)) {
      return done(null, q)
    }

This needs to be deprecated in the favor of native$.
String in this position should be an opaque id

The test case: https://github.com/senecajs/seneca-store-test/blob/master/store-test.js#L557

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant