Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing image breaks RSS feed #141

Open
kaittodesk opened this issue Sep 4, 2024 · 0 comments
Open

Missing image breaks RSS feed #141

kaittodesk opened this issue Sep 4, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@kaittodesk
Copy link
Member

Bug description
When a product without an image matches RSS feed filter criteria and PHP's display_errors option is set to On, the RSS feed will also output warning:

Warning: Trying to access array offset on value of type bool in /path/to/wordpress/wp-content/plugins/smaily-for-woocommerce/inc/Base/DataHandler.php on line 105

Steps for reproducing

  1. Enable display_errors = On for your WordPress installation.
  2. Go to your WordPress site admin.
  3. Create a product without an image.
  4. Go to Smaily for WooCommerce settings and create an RSS feed URL returning created product.
  5. Navigate to the RSS feed URL.

Expected behavior
Missing product image is handled gracefully.

Actual behavior
A warning is displayed to the end user, breaking the RSS feed.

Versions
WordPress 6.6.1
WooCommerce 9.1.4
Smaily for WooCommerce 1.11.2

@kaittodesk kaittodesk added the bug Something isn't working label Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant