Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transport object not set when relay is disabled #10

Open
adamkarnowka opened this issue May 28, 2020 · 0 comments
Open

Transport object not set when relay is disabled #10

adamkarnowka opened this issue May 28, 2020 · 0 comments

Comments

@adamkarnowka
Copy link

Hi, please take a look at:
https://github.com/sendinblue/magento2-plugin/blob/master/Model/Transport.php#L57

In case $relaySib is not enabled - nothing happens, $this->transport remains null, therefore sendMessage() will do literally nothing - as a result no single transactional e-mail in Magento can be sent.

As a fix, $this->transport = new Zend\Mail\Transport\Sendmail($parameters); can be added in constructor method to provide default fallback solution in case SMTP communication is disabled.

Kind regards,
Adam

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant