Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to create new Analysis Services due to validation requirements of UpperDetectionLimit and LowerDetectionLimit #28

Open
Perseus opened this issue Jul 28, 2018 · 2 comments

Comments

@Perseus
Copy link

Perseus commented Jul 28, 2018

Steps to reproduce

Send a POST request to the analysisservice route to create a new Analysis Service with data in JSON format.

Current behavior

Validation fails, with the error message that the LDL and UDL fields expect a string but when I send a string, it expects an integer

Expected behavior

Analysis Service is succesfully created

Screenshot (optional)

image

@ramonski
Copy link
Contributor

@aethelwulffe
Copy link

Hi, just wandered in to look into the status of this. I got no python under my belt, but I guess what I am hearing is that if you throw a value of one type, it returns an error saying it needs a different data type, and changes it's mind if you do the reverse, right? Solution being creating a class (archetype?) to handle the value and error checking of that specific defined field, as without, error checking defaults always results in an opposing error? Specificity being great if the field is often/always employed, but if otherwise, maybe a loose datatype check?
...Like I said, not a PY guy, just trying to be informed to answer the great level of anticipation and curiosity that LibreHealthIO/lh-ehr#1204 is generating, and will result in questions directed to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants