Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Registered Sample not exported correctly in ISA-JSON #2058

Open
kdp-cloud opened this issue Nov 13, 2024 · 0 comments
Open

Registered Sample not exported correctly in ISA-JSON #2058

kdp-cloud opened this issue Nov 13, 2024 · 0 comments
Assignees
Labels
Milestone

Comments

@kdp-cloud
Copy link
Collaborator

When a Sample Type has other Registered samples, besides the input from the previous Sample Type, the Registered Sample is exported as plain JSON in the ISA-JSON. This is not conform to the JSON schema of a characteristic.

Example:

{
    "category": { "@id": "#characteristic_category/Sample_1558" },
    "value": {
      "annotationValue": {
        "id": 762,
        "type": "Sample",
        "title": "Viscosin"
      },
      "termSource": "",
      "termAccession": ""
}
@kdp-cloud kdp-cloud added the bug label Nov 13, 2024
@kdp-cloud kdp-cloud added this to the 1.16.0 milestone Nov 13, 2024
@kdp-cloud kdp-cloud self-assigned this Nov 13, 2024
@github-project-automation github-project-automation bot moved this to Requirements in DataHub Nov 13, 2024
@stuzart stuzart modified the milestones: 1.16.0, 1.16.1 Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Requirements
Status: No status
Development

No branches or pull requests

2 participants