Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make samples extracted from datafile editable #1357

Closed
floradanna opened this issue Feb 14, 2023 · 2 comments · Fixed by #1599
Closed

Make samples extracted from datafile editable #1357

floradanna opened this issue Feb 14, 2023 · 2 comments · Fixed by #1599
Assignees
Labels
Milestone

Comments

@floradanna
Copy link
Collaborator

Problem: samples extracted from a datafile cannot be edited because they are forever bound to the information provided in the datafile.

Solution: samples extracted from a datafile should be editable after extraction, as any other samples in SEEK.

Process:

  • the user goes to "edit sample",
  • if sample has been extracted from a datafile, SEEK shows a warning "Sample has been extracted from a datafile, editing this sample will make the datafile not valid anymore for this sample" or something.
  • if user continue editing, the datafile link for that sample will gain the label "not valid anymore"

Process for editing a sample type that has a linked datafile: same process as described for the editing of samples

@stuzart
Copy link
Member

stuzart commented Feb 17, 2023

this relates to #1136 and involves decoupling the permissions and projects from the datafile. The datafile could just provide the defaults

@stuzart stuzart added this to the v1.14.0 milestone Feb 17, 2023
@stuzart
Copy link
Member

stuzart commented Feb 17, 2023

also #1356

@stuzart stuzart modified the milestones: v1.14.0, v1.15.0 Jul 5, 2023
@floradanna floradanna moved this to Requirements in DataHub Jul 26, 2023
@floradanna floradanna moved this from Requirements to Backlog in DataHub Aug 1, 2023
@floradanna floradanna moved this from Backlog to In Progress in DataHub Oct 3, 2023
@fherreazcue fherreazcue linked a pull request Oct 4, 2023 that will close this issue
@floradanna floradanna moved this from In Progress to Merged in DataHub Oct 5, 2023
@kdp-cloud kdp-cloud moved this from Merged to Released in DataHub Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Released
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants