Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate the sample code in source.go #1074

Closed
adambkaplan opened this issue Nov 26, 2023 · 3 comments
Closed

Separate the sample code in source.go #1074

adambkaplan opened this issue Nov 26, 2023 · 3 comments

Comments

@adambkaplan
Copy link
Contributor

Summary

The sample code used to run tests currently exists in a single, massive file (source.go). Contributing additional test samples to this file can be daunting due to its size. This "enhancement" proposes splitting this code up to separate files that are easier for contributors to read - perhaps organized by issue that gosec checks.

@adambkaplan
Copy link
Contributor Author

One potential approach (I would be happy to turn this into a pull request): https://github.com/securego/gosec/compare/master...adambkaplan:split-source-examples?expand=1

@ccojocar
Copy link
Member

It sounds like a good improvement. We can split it per rules in smaller files.

@ccojocar
Copy link
Member

ccojocar commented Dec 8, 2023

fixed by #1085

@ccojocar ccojocar closed this as completed Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants