Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor updates to docker Makefile and scan job #967

Merged
merged 1 commit into from
May 17, 2024

Conversation

ashahba
Copy link
Collaborator

@ashahba ashahba commented May 2, 2024

This PR:

  • updates Makefile and Trivy workspace file so that the docker build always pulls latest base ubuntu:22.04 first
  • updates Makefile so that the container is saved in gzip format rather than tar so the saved image has a smaller footprint:
$ du -sh openfl.tar*
1.2G 	openfl.tar
463M	openfl.tar.gz
  • Removes stock ssh keys installed under /etc/ssh/ by openssh server, since they are not needed and also Trivy flags them incorrectly as secrets left on the container.

@ashahba ashahba requested a review from psfoley May 2, 2024 05:19
Copy link
Contributor

@psfoley psfoley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ashahba! Approved

@psfoley psfoley merged commit 9ba5412 into securefederatedai:develop May 17, 2024
25 of 26 checks passed
manuelhsantana pushed a commit that referenced this pull request Jul 10, 2024
Signed-off-by: Abolfazl Shahbazi <[email protected]>
Signed-off-by: manuelhsantana <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants