Adding Workflow Interface FedProx Example with Synthetic Dataset #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParthM-GitHub
force-pushed
the
fedprox_example
branch
from
d39ae96 to
cbafbad
Compare
ParthM-GitHub
force-pushed
the
fedprox_example
branch
2 times, most recently
from
3d30091 to
a58b569
Compare
ParthM-GitHub
force-pushed
the
fedprox_example
branch
from
e3b6800 to
25073b8
Compare
Signed-off-by: ParthM-GitHub <[email protected]>
1. 10 Selected Collaborators, 30 Total Collaborators, with 200 Rounds (FedProx vs FedAvg) 2. 20 Selected Collaborators, 100 Total Collaborators, with 200 Rounds (FedProx vs FedAvg) 3. 10 Selected Collaborators, 30 Total Collaborators, with 200 Rounds (FedProx vs FedAvg) Tested on Google Colab Signed-off-by: ParthM-GitHub <[email protected]>
Signed-off-by: ParthM-GitHub <[email protected]>
Signed-off-by: ParthM-GitHub <[email protected]>
Signed-off-by: ParthM-GitHub <[email protected]>
Signed-off-by: ParthM-GitHub <[email protected]>
Signed-off-by: ParthM-GitHub <[email protected]>
Made changes required to run the example with numpy 1.24.x version. Signed-off-by: ParthM-GitHub <[email protected]>
Change github Python badge's Signed-off-by: Alexey Gruzdev <[email protected]> Signed-off-by: ParthM-GitHub <[email protected]>
Picture for the Contributing.md Signed-off-by: ParthM-GitHub <[email protected]>
Signed-off-by: ParthM-GitHub <[email protected]>
Signed-off-by: ParthM-GitHub <[email protected]>
Signed-off-by: ParthM-GitHub <[email protected]>
Signed-off-by: ParthM-GitHub <[email protected]>
Signed-off-by: Patrick Foley <[email protected]> Signed-off-by: ParthM-GitHub <[email protected]>
Signed-off-by: ParthM-GitHub <[email protected]>
Signed-off-by: ParthM-GitHub <[email protected]>
* Fix variable name Signed-off-by: Ilya Trushkin <[email protected]> * Use CONTINUE_GLOBAL treatment in FedProx tutorial Signed-off-by: Ilya Trushkin <[email protected]> --------- Signed-off-by: Ilya Trushkin <[email protected]> Signed-off-by: ParthM-GitHub <[email protected]>
ParthM-GitHub
force-pushed
the
fedprox_example
branch
from
42d746d to
28c90a4
Compare
mansishr
reviewed
Feb 28, 2023
| " This is the 'end' step.\n", | ||
| " \"\"\"\n", | ||
| " self.round_number += 1\n", | ||
| " print('This is end of the flow')" |
There was a problem hiding this comment.
This print statement is misleading because it gets printed after every round. Let's pass total_rounds to federated flow and print this condition once at the end of the flow.
mansishr
reviewed
Feb 28, 2023
| " return accuracy, test_loss, correct\n", | ||
| "\n", | ||
| "\n", | ||
| "def weighted_average(tensors, weights):\n", |
There was a problem hiding this comment.
I propose that we create openfl.experimental.interface.aggregation_functions and move this function there.
mansishr
reviewed
Mar 1, 2023
| "source": [ | ||
| "!pip install git+https://github.com/intel/openfl.git\n", | ||
| "!pip install -r https://raw.githubusercontent.com/intel/openfl/develop/openfl-tutorials/experimental/requirements_workflow_interface.txt\n", | ||
| "!pip install matplotlib\n", |
There was a problem hiding this comment.
!pip install seaborn is missing
1. Converted flow to internal loop flow 2. Added seaborn library install command Signed-off-by: ParthM-GitHub <[email protected]>
1. PyTorch: openfl/experimental/interface/keras/aggregation_functions/weighted_average.py 2. Keras: openfl/experimental/interface/keras/aggregation_functions/weighted_average.py (with NotImplementedError) 3. PyTorch Weighted average testcase in tests/openfl/experimental/test_weighted_average.py Signed-off-by: ParthM-GitHub <[email protected]>
Signed-off-by: ParthM-GitHub <[email protected]>
Signed-off-by: ParthM-GitHub <[email protected]>
Signed-off-by: ParthM-GitHub <[email protected]>
Signed-off-by: Parth Mandaliya <[email protected]>
Signed-off-by: Parth Mandaliya <[email protected]>
Signed-off-by: Parth Mandaliya <[email protected]>
|
@ParthMandaliya can you please resolve the comments/conflicts and request for review again? |
|
@theakshaypant This 401 FedProx tutorial has already been merged via a different PR, and is available under openfl-tutorials/experimental/workflow directory. cc: @ishant162 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION:
Workflow Interface Tutorial for FedProx with Synthetic non-IID Dataset.
SUMMARY:
Validated the Tutorial for following scenarios:
Executed for 30 Total Collaborators, 10 Selected Collaborators, non-IID, and 200 Rounds
Executed for 100 Total Collaborators, 20 Selected Collaborators, non-IID, and 200 Rounds
Executed for 30 Total Collaborators, 10 Selected Collaborators, IID, and 200 Rounds
Validated in Google Collab