From 86d018004715e5aeda68abdcf94cd60d00d56a84 Mon Sep 17 00:00:00 2001 From: Sean Conroy Date: Mon, 22 Jul 2024 09:17:14 +0100 Subject: [PATCH] Resolve comments --- docs/resources/feature_device_template.md | 2 +- gen/definitions/generic/feature_device_template.yaml | 2 +- gen/definitions/generic/traffic_data_policy_definition.yaml | 2 -- internal/provider/resource_sdwan_feature_device_template.go | 2 +- 4 files changed, 3 insertions(+), 5 deletions(-) diff --git a/docs/resources/feature_device_template.md b/docs/resources/feature_device_template.md index 031e9f63..0ba3636e 100644 --- a/docs/resources/feature_device_template.md +++ b/docs/resources/feature_device_template.md @@ -57,7 +57,7 @@ Required: - `id` (String) Feature template ID - `type` (String) Feature template type - - Choices: `cisco_system`, `cisco_logging`, `cedge_aaa`, `cisco_bfd`, `cisco_omp`, `cisco_security`, `cisco_banner`, `cisco_snmp`, `cedge_global`, `cli-template`, `cisco_sig_credentials`, `switchport`, `cisco_thousandeyes`, `cisco_vpn`, `application-utd` + - Choices: `cisco_system`, `cisco_logging`, `cedge_aaa`, `cisco_bfd`, `cisco_omp`, `cisco_security`, `cisco_banner`, `cisco_snmp`, `cedge_global`, `cli-template`, `cisco_sig_credentials`, `switchport`, `cisco_thousandeyes`, `cisco_vpn`, `virtual-application-utd` Optional: diff --git a/gen/definitions/generic/feature_device_template.yaml b/gen/definitions/generic/feature_device_template.yaml index cb015fbc..6ea6e0a5 100644 --- a/gen/definitions/generic/feature_device_template.yaml +++ b/gen/definitions/generic/feature_device_template.yaml @@ -87,7 +87,7 @@ attributes: tf_name: type type: String mandatory: true - enum_values: [cisco_system, cisco_logging, cedge_aaa, cisco_bfd, cisco_omp, cisco_security, cisco_banner, cisco_snmp, cedge_global, cli-template, cisco_sig_credentials, switchport, cisco_thousandeyes, cisco_vpn, application-utd] + enum_values: [cisco_system, cisco_logging, cedge_aaa, cisco_bfd, cisco_omp, cisco_security, cisco_banner, cisco_snmp, cedge_global, cli-template, cisco_sig_credentials, switchport, cisco_thousandeyes, cisco_vpn, virtual-application-utd] ignore_enum: true description: Feature template type example: cisco_system diff --git a/gen/definitions/generic/traffic_data_policy_definition.yaml b/gen/definitions/generic/traffic_data_policy_definition.yaml index 04a61285..48c45d70 100644 --- a/gen/definitions/generic/traffic_data_policy_definition.yaml +++ b/gen/definitions/generic/traffic_data_policy_definition.yaml @@ -389,8 +389,6 @@ attributes: value: lossProtectFec type: String description: Loss correction FEC threshold - # min_int: 1 - # max_int: 5 example: 2 exclude_test: true - model_name: field diff --git a/internal/provider/resource_sdwan_feature_device_template.go b/internal/provider/resource_sdwan_feature_device_template.go index 0a2888de..adf4a7f2 100644 --- a/internal/provider/resource_sdwan_feature_device_template.go +++ b/internal/provider/resource_sdwan_feature_device_template.go @@ -125,7 +125,7 @@ func (r *FeatureDeviceTemplateResource) Schema(ctx context.Context, req resource Optional: true, }, "type": schema.StringAttribute{ - MarkdownDescription: helpers.NewAttributeDescription("Feature template type").AddStringEnumDescription("cisco_system", "cisco_logging", "cedge_aaa", "cisco_bfd", "cisco_omp", "cisco_security", "cisco_banner", "cisco_snmp", "cedge_global", "cli-template", "cisco_sig_credentials", "switchport", "cisco_thousandeyes", "cisco_vpn", "application-utd").String, + MarkdownDescription: helpers.NewAttributeDescription("Feature template type").AddStringEnumDescription("cisco_system", "cisco_logging", "cedge_aaa", "cisco_bfd", "cisco_omp", "cisco_security", "cisco_banner", "cisco_snmp", "cedge_global", "cli-template", "cisco_sig_credentials", "switchport", "cisco_thousandeyes", "cisco_vpn", "virtual-application-utd").String, Required: true, }, "sub_templates": schema.SetNestedAttribute{