From 23fe84e055b118598e79ac07d455f1ffceddc6db Mon Sep 17 00:00:00 2001 From: seawinde Date: Tue, 26 Dec 2023 11:03:49 +0800 Subject: [PATCH] modify the comment --- .../doris/nereids/rules/rewrite/PredicatePropagation.java | 2 -- .../java/org/apache/doris/nereids/util/ExpressionUtils.java | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/PredicatePropagation.java b/fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/PredicatePropagation.java index aff8b36bc36116..45831abbee906b 100644 --- a/fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/PredicatePropagation.java +++ b/fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/PredicatePropagation.java @@ -88,8 +88,6 @@ public ComparisonInferInfo(InferType inferType, public Set infer(Set predicates) { Set inferred = Sets.newHashSet(); for (Expression predicate : predicates) { - // if we support more predicate infer, we should add .withInferred(this.isInferred()) - // to mark the predicate is from infer when call withChildren method if (!(predicate instanceof ComparisonPredicate)) { continue; } diff --git a/fe/fe-core/src/main/java/org/apache/doris/nereids/util/ExpressionUtils.java b/fe/fe-core/src/main/java/org/apache/doris/nereids/util/ExpressionUtils.java index 51f481b51ac32c..b9c240df415f49 100644 --- a/fe/fe-core/src/main/java/org/apache/doris/nereids/util/ExpressionUtils.java +++ b/fe/fe-core/src/main/java/org/apache/doris/nereids/util/ExpressionUtils.java @@ -642,7 +642,7 @@ public static boolean checkSlotConstant(Slot slot, Set predicates) { } /** - * isInferred + * Check the expression is inferred or not, if inferred return true, nor return false */ public static boolean isInferred(Expression expression) { return expression.accept(new DefaultExpressionVisitor() {