Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

carousel component should auto create the scrollbar divs when scrollbar module is provided #1207

Open
chrisFrazier77 opened this issue Nov 18, 2024 · 1 comment

Comments

@chrisFrazier77
Copy link
Contributor

chrisFrazier77 commented Nov 18, 2024

https://github.com/searchspring-implementations/shonajoy.com.au/blob/652f3c88403a721096215bb66e32169690e0cd82/src/recommendations/carousel/Carousel.jsx#L212

example of implementations having to manually add the scrollbar div.

@korgon
Copy link
Contributor

korgon commented Nov 20, 2024

I tested this the other week and as long as the module is provided and a minimal config the DOM elements are created without having to do so manually.

import { Scrollbar } from 'swiper/modules';

<Recommendation modules={[Scrollbar]} scrollbar={{ enabled: true }} controller={controller}>
	...
</Recommendation>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants