Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate namespace pages #439

Merged
merged 24 commits into from
Nov 28, 2024
Merged

Generate namespace pages #439

merged 24 commits into from
Nov 28, 2024

Conversation

andrii-balitskyi
Copy link
Contributor

@andrii-balitskyi andrii-balitskyi commented Nov 22, 2024 •
edited
Loading

Closes #399

  • Generate namespace pages
  • Report untitled namespaces

@andrii-balitskyi andrii-balitskyi requested a review from a team as a code owner November 22, 2024 16:14
@seambot seambot requested a review from a team as a code owner November 22, 2024 16:20
razor-x
razor-x reviewed Nov 22, 2024
View reviewed changes
src/data/paths.yaml Outdated Show resolved Hide resolved
razor-x
razor-x reviewed Nov 22, 2024
View reviewed changes
src/layouts/api-namespace.hbs Outdated Show resolved Hide resolved
src/lib/layout/api-namespace.ts Outdated Show resolved Hide resolved
DebbieAtSeam
DebbieAtSeam reviewed Nov 22, 2024
View reviewed changes
src/layouts/api-namespace.hbs Outdated Show resolved Hide resolved
src/layouts/api-namespace.hbs Outdated Show resolved Hide resolved
docs/api/acs/README.md Show resolved Hide resolved
docs/api/acs/README.md Outdated Show resolved Hide resolved
src/data/paths.yaml Show resolved Hide resolved
@razor-x
Copy link
Contributor

razor-x commented Nov 22, 2024

@andrii-balitskyi We need to update all links (find / replace) to point to this file now instead of api-clients/acs and update the summary so we can preview it on gitbook

docs/docs/SUMMARY.md

Line 167 in 6a5cf81

* [Access Control Systems](api-clients/acs/README.md)

@andrii-balitskyi
Copy link
Contributor Author

@razor-x replaced all api-clients/acs links with api/acs here f5921a5

razor-x
razor-x reviewed Nov 25, 2024
View reviewed changes
src/lib/reference.ts Outdated Show resolved Hide resolved
docs/api/acs/README.md Outdated

## Resources

### `acs_system`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add the links, I think this would be correct.

Suggested change
### `acs_system`
### [`acs_system`](./systems/README.md#acs_system)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if I correctly compute the link using pathMetadata c3dbdf0

razor-x
razor-x reviewed Nov 25, 2024
View reviewed changes
.gitbook.yaml Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrii-balitskyi This file must remain unchanged or it will break all of the redirects from the old URLs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted the file in def5b59

@andrii-balitskyi andrii-balitskyi merged commit 6bc7ac8 into main Nov 28, 2024
13 checks passed
@andrii-balitskyi andrii-balitskyi deleted the api-namespace-page branch November 28, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DebbieAtSeam DebbieAtSeam DebbieAtSeam left review comments

@razor-x razor-x razor-x approved these changes

Assignees

@andrii-balitskyi andrii-balitskyi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generate namespace pages
4 participants
@andrii-balitskyi @razor-x @DebbieAtSeam @seambot