Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some invalid cron expressions show unhelpful error message #45

Open
joe4dev opened this issue Apr 21, 2020 · 0 comments
Open

Some invalid cron expressions show unhelpful error message #45

joe4dev opened this issue Apr 21, 2020 · 0 comments

Comments

@joe4dev
Copy link
Contributor

joe4dev commented Apr 21, 2020

Entering some invalid cron expressions leads to unhelp error messages.
Note: the feature works when entering valid or obviously incorrect cron expressions, so this is a minor issue.

It happens with 0 24 * * * (hours out of bounds) but not with 0 23 * * * (which is valid)

When trying to create an active schedule:

Failed to update system crontab.

Screenshot 2020-04-22 at 00 24 01

When trying to create an inactive schedule:

`undefined method `+' for nil:NilClass`

This could potentially break the benchmark definitions view if "corrupted" schedules somehow get through validation because Cron2English then fails when rendering the view.

Ideas:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant