Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for splitting into equally-sized windows (#49 and PR #140) #141

Closed
clhunsen opened this issue Sep 18, 2018 · 0 comments
Closed

Comments

@clhunsen
Copy link
Collaborator

clhunsen commented Sep 18, 2018

Description

With the final fix for issue #49 in PR #140, we definitely need tests for splitting data and networks based on a given amount of time windows (see also #140 (comment)).

Motivation

Tests are good! 😁

Ideas for the Implementation

We have three functions to test:

  • split.data.time.based,
  • split.network.time.based, and
  • split.networks.time.based.

A test for the also affected function split.get.bins.time.based has been added in commit 8d80fa9 already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants