From c64cab84e928a2a4c89a6df12440ba7ca06e6263 Mon Sep 17 00:00:00 2001 From: Claus Hunsen Date: Mon, 5 Nov 2018 15:08:16 +0100 Subject: [PATCH 1/2] Fix error when resetting an ProjectData environment When calling the method 'ProjectData$reset.environment()', an error is produced: > Error in private$artifacts = NULL : > cannot add bindings to a locked environment This is due a regression introduced in commit 1bed431bf21d78936391a5e7278de5f762922eac, where the field 'ProjectData$artifacts' has been removed, but not the corresponding statement for resetting it. This is fixed now. Signed-off-by: Claus Hunsen --- util-data.R | 1 - 1 file changed, 1 deletion(-) diff --git a/util-data.R b/util-data.R index 0ec419cc..80cd16eb 100644 --- a/util-data.R +++ b/util-data.R @@ -289,7 +289,6 @@ ProjectData = R6::R6Class("ProjectData", private$commits.filtered = NULL private$commits.filtered.empty = NULL private$commits = NULL - private$artifacts = NULL private$synchronicity = NULL private$mails = NULL private$authors = NULL From 3064a491cde2d164811d0e1434dfff698bfaa8f1 Mon Sep 17 00:00:00 2001 From: Claus Hunsen Date: Mon, 5 Nov 2018 15:10:45 +0100 Subject: [PATCH 2/2] Update changelog Signed-off-by: Claus Hunsen --- NEWS.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/NEWS.md b/NEWS.md index 7e02f640..87dbfece 100644 --- a/NEWS.md +++ b/NEWS.md @@ -5,6 +5,9 @@ ### Changed/Improved - Change shape of `Vertices` in the legend of plots to avoid confusion (f4fb4807cfd87d9d552a9ede92ea65ae4a386a04) +### Fixed +- Fix error when resetting an `ProjectData` environment (c64cab84e928a2a4c89a6df12440ba7ca06e6263) + ## 3.4