Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with version bump script #53

Open
jkeljo opened this issue Jan 6, 2022 · 5 comments
Open

Issues with version bump script #53

jkeljo opened this issue Jan 6, 2022 · 5 comments

Comments

@jkeljo
Copy link
Collaborator

jkeljo commented Jan 6, 2022

I ran the version bump script, and a couple confusing things happened.

[0] > python scripts/version_bump.py 
Cutting release 0.3.0 from 1319a49404716dfbe2e9b48cd8cb40c73622f53e
Release branch for v0.3 has been created.
Please go to https://github.com/sdwilsh/siobrultech-protocols/releases/new to create a new release for v0.3.
Updating main to use version 0.4.0a0 now that 0.3.0 is branched.
Please go to https://github.com/sdwilsh/siobrultech-protocols/pull/new/v0.4.0a0-version-bump to open a pull request.

Quick background: on my working copy upstream is sdwilsh/siobrultech-protocols and origin is jkeljo/siobrultech-protocols.

  1. Even though my (detached) HEAD was on upstream/main, it branched from origin/main for the version bump. I hadn't updated that branch in a while, so it thought that 3.0 was the correct next release.
  2. That second link (for the pull request) isn't correct; the username should be jkeljo

I'm going to clean up what it did to my fork, update my main branch and try again. Will report back if I run into anything else.

@jkeljo
Copy link
Collaborator Author

jkeljo commented Jan 6, 2022

The next weird thing is that the release branch was created in my fork, so I'm not able to create a release off of that. (I think I ought to be able to manually work around that.)

@jkeljo
Copy link
Collaborator Author

jkeljo commented Jan 6, 2022

One other thing that is odd, but I don't think we can do anything about, is that v0.4.1...v0.5 shows the fixes that were done between v0.4.0 and v0.4.1. It makes sense that it shows the commits (they were made in both main and the servicing branch), but what I really don't get is why it also shows the changes to the source files.

@jkeljo
Copy link
Collaborator Author

jkeljo commented Jan 6, 2022

Another weirdness: GitHub's "Auto-generate release notes" generates "What's Changed" with everything since the beginning of time.

@sdwilsh
Copy link
Owner

sdwilsh commented Apr 19, 2022

It sounds like this script only works if you clone from this repo as your origin, which you can do as a collaborator, FWIW. That's probably not optimal for how you normally hack on this though :/

I suspect your last two comments are related. I don't know how GitHub wants me to release cuts, but apparently the seemingly normal way I'm doing it isn't it.

@sdwilsh
Copy link
Owner

sdwilsh commented Apr 10, 2023

Another weirdness: GitHub's "Auto-generate release notes" generates "What's Changed" with everything since the beginning of time.

It looks like GitHub lets you pick a tag now to generate notes off of, and that actually works (although auto doesn't).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants